spring-projects / spring-projects/spring-data-commons
EvaluationContextExtension should have access to original properties [DATACMNS-560]
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 838
- Forks
- 730
- PR merge metrics
- No merged PRs in 30d
Description
Rob Winch opened DATACMNS-560 and commented
I've been working through Security and Reactor a bit and there are use cases with Security and Reactor that we want to avoid using a ThreadLocal. In these instances we calculate the SecurityContext based upon arguments passed into methods.
For this reason, it would be good if the EvaluationContextExtension had access to the existing properties (i.e. method arguments, annotations, etc) to allow determining the SecurityContext from method arguments
Affects: 1.9 M1 (Evans)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the EvaluationContextExtension entry point and the code that constructs its evaluation context. Trace how method arguments and annotations are currently handled, then determine the intended contract for exposing those original properties so a SecurityContext can be derived without ThreadLocal state. Done means the behavior is specified and covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend-api-design
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100