spring-projects / spring-projects/spring-boot
spring-boot-loader does not consistently handle shorts correctly
Open
Nobody has claimed this yet.
status: team-only
type: bug
- Dominant language
- Java
- Stars
- 81.5k
- Forks
- 42.7k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 65
Description
With thanks to @unknownhad for bringing this to our attention, there are a few places where we allow a short to become an int with sign extension, resulting in a negative value. We need to use Short.toUnsignedInt() consistently.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by searching the spring-boot-loader sources for places where short values are converted to int, then inspect the surrounding handling for sign extension. Replace the inconsistent conversions with unsigned handling and verify that all affected values remain non-negative, using the loader's existing tests if available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring-boot
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100