spring-projects / spring-projects/spring-boot
Consider creating observations in MetricsRepositoryMethodInvocationListener
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 81.5k
- Forks
- 42.7k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 65
Description
It's surprisingly hard to get observations from Spring Data repository invocations. Annotating the repository interface with @Observed doesn't work. We create metrics in MetricsRepositoryMethodInvocationListener, maybe we can use this to also create observations?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading MetricsRepositoryMethodInvocationListener and the existing metric creation path. Compare that path with how @Observed observations are created and determine the expected behavior for Spring Data repository invocations. Done means repository calls produce the intended observations without breaking the existing metrics behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring-boot
- Domain
- observability
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100