spring-projects / spring-projects/spring-boot
Review the need for TomcatAccess, JettyAccess, and UndertowAccess
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 81.5k
- Forks
- 42.7k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 65
Description
They're test classes used to provide public access to otherwise package-private methods. It would be good to review the code and see if we can remove the need for them as part of the restructuring efforts. TomcatAccess is somewhat related to #44325 as it may be addressed by having servlet- and reactive-specific TomcatWebServer sub-classes.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the TomcatAccess, JettyAccess, and UndertowAccess test classes and the package-private methods they expose. Review the restructuring context in issue #44325, especially the proposed servlet- and reactive-specific TomcatWebServer subclasses. Done means determining whether each access class can be removed and documenting or implementing the resulting restructuring.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring-boot
- Domain
- backend, testing
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100