spring-projects / spring-projects/spring-boot
Add auto-configuration for Observations in Spring-WS
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 81.5k
- Forks
- 42.7k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 65
Description
I have added support for Observations in Spring-WS, and the next step would be to add auto-configuration for the ObservationInterceptors.
As far as I can tell, it could perhaps be implemented in the module spring-boot-actuator-autoconfigure under the package
org.springframework.boot.actuate.autoconfigure.observation.webservice.client or org.springframework.boot.actuate.autoconfigure.observation.webservice.server
For the WebServiceTemplate, the interceptor could probably be added by implementing a WebServiceTemplateCustomizer that is added to the context.
Condition for activating the configuration class could perhaps be @ConditionalOnBean(ObservationRegistry.class)
For the server Endpoints, the interceptor could probably be added in the addInterceptors-callback in the WsConfigurerAdapter.
Condition for activating the configuration class could perhaps be @ConditionalOnBean(ObservationRegistry.class)
The new Observation was merged in https://github.com/spring-projects/spring-ws/pull/1438 for the issue
https://github.com/spring-projects/spring-ws/issues/1094
This is also related to https://github.com/spring-projects/spring-boot/issues/15390
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in spring-boot-actuator-autoconfigure and review the proposed webservice.client and webservice.server packages, along with WebServiceTemplateCustomizer and the WsConfigurerAdapter addInterceptors callback. Use the linked Spring-WS observation work as context. Done means ObservationInterceptors are auto-configured for client and server endpoints when an ObservationRegistry is present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring-boot
- Domain
- observability
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100