spring-projects / spring-projects/spring-boot

Add DynamicPropertyContributor

Open
#37,074 6 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

status: pending-design-work type: enhancement
Dominant language
Java
Stars
81.5k
Forks
42.7k
Avg merge
2d 4h
Merged PRs (30d)
65

Description

Currently DynamicPropertyRegistry can be used as a parameter on @Bean methods or test methods annotated with @DynamicPropertySource. If we have a DynamicPropertyContributor type we could return it. This would also allow us to ensure that TestcontainersLifecycleBeanPostProcessor could initialize them early.

The code would look like this:

@Bean
DynamicPropertyContributor dynamicPropertyContributor() {
    return (registry) -> {
            registry.add("spring.data.redis.host", redis()::getHost);
            registry.add("spring.data.redis.port", redis()::getFirstMappedPort);
    }
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading DynamicPropertyRegistry, the @DynamicPropertySource handling, and TestcontainersLifecycleBeanPostProcessor. Trace how @Bean methods and test methods currently receive registries. Done means a DynamicPropertyContributor can be returned from a bean method and is initialized early enough for the lifecycle post-processor to use it.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring-boot
Domain
testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.