spring-projects / spring-projects/spring-boot

Servlet Filters not applied to management context

Open
#31,811 7 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

type: enhancement
Dominant language
Java
Stars
81.5k
Forks
42.7k
Avg merge
2d 4h
Merged PRs (30d)
65

Description

Spring boot webmvc service and spring boot webflux service have inconsistent behavior for http server requests metrics(prometheus). Webflux service exposes http_server_requests_seconds that includes metrics for management endpoints and service endpoints but for webmvc there are only metrics for service endpoints. I am attaching the minimal example(for spring boot v2.6.9) to be more clear.

spring-http-server-metrics.zip

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the attached spring-http-server-metrics.zip and run its minimal Spring Boot 2.6.9 examples. Compare the WebMVC and WebFlux HTTP server metrics for service and management endpoints; done means WebMVC exposes management-endpoint metrics consistently with WebFlux.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, prometheus, spring-boot
Domain
backend, observability
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.