spring-projects / spring-projects/spring-boot
Allow customizing rabbitmq metrics prefix
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 81.5k
- Forks
- 42.7k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 65
Description
Metrics for rabbitmq are bound using Micrometer to the prefix rabbitmq (https://github.com/spring-projects/spring-boot/blob/b8983cef590686a3b1d23ffef4113b024a9a13e3/spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/metrics/amqp/RabbitMetrics.java#L55)
@Override
public void bindTo(MeterRegistry registry) {
this.connectionFactory.setMetricsCollector(new MicrometerMetricsCollector(registry, "rabbitmq", this.tags));
}
This is the same domain as rabbitmq server metrics and it can be confusing to pick these apart (I've seen recommendations for scoping them to rabbitmq.client). It would be nice to be able to customize this!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with RabbitMetrics.java at the bindTo method linked in the issue, and inspect how MicrometerMetricsCollector currently receives the fixed "rabbitmq" prefix. The work is done when the RabbitMQ metrics prefix can be customized instead of always using that value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, rabbitmq, spring-boot
- Domain
- observability
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100