spring-projects / spring-projects/spring-boot
Graceful shutdown for RSockets
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 81.5k
- Forks
- 42.7k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 65
Description
Along the lines of WebServer.shutDownGracefully() it would be good to be able to control the shutdown of an RSockets app (client and server). Right now, I think all you can do is ApplicationContext.close() and that leads to potentially cutting off in-flight requests and channels at the knees. See also: https://github.com/rsocket/rsocket-java/issues/988.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing WebServer.shutDownGracefully() with the current ApplicationContext.close() behavior for RSockets, and review the linked rsocket/rsocket-java issue. Done should mean that both client and server applications can shut down without cutting off in-flight requests or channels.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring-boot
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100