spring-projects / spring-projects/spring-boot
Declaring a user-defined WebServerFactory should make sure the auto-configuration backs off
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 81.5k
- Forks
- 42.7k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 65
Description
See #24705
We initially designed things this way because we wanted an easy way for users to opt-in for the embedded server of their choices if they happen to have two on the classpath and the one the auto-configuration picked was not the one they wanted to use.
This corner case makes the auto-configuration at odds with others. If you register a WebServerFactory the customizers are applied anyway. This means also that whatever you configure in the factory itself is likely to be lost since default opinions are going to be applied after that.
Changing this behaviour is a breaking change that could surprise more than one user. We may want to keep the current behaviour , perhaps using a configuration property. This would help users to migrate.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by tracing WebServerFactory auto-configuration and where customizers are applied; compare that behavior with the requested back-off rule and the compatibility concern. Done should be a decided behavior, including whether a configuration property is needed to preserve the current behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring-boot
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100