spring-projects / spring-projects/spring-boot
Make it easier for the error controller and the error attributes to be sure that they agree on the status of the response
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 81.5k
- Forks
- 42.7k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 65
Description
See #20412 for background.
As things stand, it's possible for the error controller to set one status on the response while the error attributes implementation includes another in an entry in the model. Ideally, the API would guide things towards an arrangement that would minimise the possibility of this happening. That could be done by retrieving the value that's keyed by status from the ErrorAttributes or, perhaps, via a new method on ErrorAttributes that passes in the status that the error controller is going to set on the response. The former probably does a better job of minimising the chance of an inconsistency while the latter avoids requiring the response status to have the key status.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read #20412 for the background, then inspect the error controller and ErrorAttributes implementations to understand how each determines the response status. The work is done when the API guides both components toward a single consistent status, using one of the alternatives described in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring-boot
- Domain
- backend-api-design
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100