spring-projects / spring-projects/spring-boot
Stop disabling metrics export auto-configuration when related enable flag is disabled
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 81.5k
- Forks
- 42.7k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 65
Description
Relates to #13408
We also have one enabled flag per monitoring system we support. This one is different as there is a direct counter part in micrometer itself.
Right now, we back-off if the flag is set to false which means that we never effectively set the Micrometer flag to false (we just don't auto-configure anything). Given the scope of this flag, we should probably remove the condition.
/cc @jkschneider
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing Spring Boot's metrics export auto-configuration and the related monitoring-system enable flag, then compare its behavior with the corresponding Micrometer flag. The change is complete when disabling the related property still auto-configures the export path and sets Micrometer's flag to false, with the existing issue relationship to #13408 considered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring-boot
- Domain
- backend, observability
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100