spring-projects / spring-projects/spring-boot
Use HikariConfig as a builder for creating the auto-configured HikariDataSource
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 81.5k
- Forks
- 42.7k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 65
Description
See https://github.com/brettwooldridge/HikariCP/issues/1096 for some background. We'll get a small performance boost in getConnection() and it'll also align us with the ideal usage of Hikari where the configuration is created and customised and then, once that's complete, it's used to create a HikariDataSource. The HikariDataSource then doesn't change (other than what's supported by Hikari's JMX integration).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the HikariCP issue linked in the description, then trace Spring Boot's auto-configured HikariDataSource creation and its HikariConfig setup. The change is complete when configuration is customised before creating the datasource, while the resulting datasource remains unchanged apart from supported Hikari JMX behaviour.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring-boot
- Domain
- backend, database
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100