spring-projects / spring-projects/spring-batch
Omitting the name from the FlatFileItemReaderBuilder results in an exception. [BATCH-2623]
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 3k
- Forks
- 2.5k
- Avg merge
- 6d 53m
- Merged PRs (30d)
- 3
Description
Marten Deinum opened BATCH-2623 and commented
During conversion of a FlatFileItemReader to the usage of the FlatFileItemReaderBuilder I ran into the issue that I now suddenly must provide a name.
The FlatFileItemReader by default sets the name to the short classname and I would expect the builder to honor this, however instead the builder itself is throwing an exception. I would expect that I don't have the explicitly name the constructed reader just as with the plain configuration.
Affects: 4.0.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the FlatFileItemReaderBuilder entry point with FlatFileItemReader's default-name behavior, then locate the builder's existing tests. Verify the behavior when no name is supplied and add a regression test showing that the builder matches the plain reader; done means that usage no longer throws an exception.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100