spring-projects / spring-projects/spring-batch

Create batch:skip-listeners [BATCH-2627]

Open
#978 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

in: core status: waiting-for-triage type: feature
Dominant language
Java
Stars
3k
Forks
2.5k
Avg merge
6d 53m
Merged PRs (30d)
3

Description

Manuel Jordan opened BATCH-2627 and commented

If currently is possible within a batch:chunk component declare:

<batch:retryable-exception-classes>
	<batch:include class="...SomeException"/>
</batch:retryable-exception-classes>
<batch:retry-listeners>
	<batch:listener ref="personItemRetryListener"/>
</batch:retry-listeners>

Why not is possible do the following?

<batch:skippable-exception-classes>
	<batch:include class="...SomeException"/>
</batch:skippable-exception-classes>
<batch:skip-listeners>
	<batch:listener ref="personItemSkipListener"/>
</batch:skip-listeners>

There is no a batch:skip-listeners element.

Currently I must use the following (observe through batch:listeners}}

<batch:skippable-exception-classes>
	<batch:include class="...SomeException"/>
</batch:skippable-exception-classes>
<batch:listeners>
	<batch:listener ref="personItemSkipListener"/>
	<batch:listener ref="personItemProcessorListener"/>
</batch:listeners>

IMHO batch:listeners should be used for:

  • ItemReadListener
  • ItemProcessListener
  • ItemWriteListener
  • ChunkListener

And thus batch:retry-listeners and batch:skip-listeners clearly more specifics.


Affects: 3.0.6, 3.0.7

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the batch:chunk XML configuration and the existing batch:retry-listeners and batch:listeners elements described in the issue. Confirm how skip listener references are currently handled, then define completion as supporting a dedicated batch:skip-listeners element alongside skippable-exception-classes without changing the existing listener behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.