ItemStreamSupport could implement BeanNameAware [BATCH-2108]

Jimmy Praet opened BATCH-2108 and commented

ItemStreamSupport has a setName() method to configure the name of the component, which will also be used as a prefix for the keys stored in the step execution context.

If ItemStreamSupport were to implement BeanNameAware this name could be set automatically by default to the bean id.

This has the added benefit that the name setter is exposed via an interface instead of via a public method on an abstract class. I mention this because in my projects I have a delegating writer where I want to propagate the name property to the delegate as follows:

@Override
public void setName(String name) {
     super.setName(name);
     if (delegate instanceof AbstractItemStreamItemWriter) {
          ((AbstractItemStreamItemWriter<?>) delegate).setName(name);
     }
}

However, this does not work if the delegate is a JDK dynamic proxy step scoped bean, because it won't be an instanceof AbstractItemStreamItemWriter.

Referenced from: pull request https://github.com/spring-projects/spring-batch/pull/292

Locate ItemStreamSupport and the surrounding Spring Batch item-stream classes, then review the referenced pull request for prior work. Check how the component name is currently configured and how bean-name awareness would affect step execution context keys; done means the bean id supplies the name by default without breaking explicit naming.