spring-projects / spring-projects/spring-ai
PromptChatMemoryAdvisor.before code contains strange comment
Open
Nobody has claimed this yet.
status: waiting-for-triage
- Dominant language
- Java
- Stars
- 9.5k
- Forks
- 2.9k
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 6
Description
Within version 1.1.2 of Spring AI PromptChatMemoryAdvisor.before line 133 there is the following comment:
// 5. Add all user messages from the current prompt to memory (after system
// message is generated)
but there is no actual code. I think this comment can be removed
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open PromptChatMemoryAdvisor.before in Spring AI 1.1.2 and inspect line 133 with the surrounding memory-update logic. Remove the comment if it documents no operation, then confirm the method is unchanged apart from that cleanup and run the relevant project checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- ai
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100