spring-projects / spring-projects/spring-ai

Injection of HttpClient.Builder for SseHttpClientTransportAutoConfiguration

Open
#4,142 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

status: waiting-for-triage
Dominant language
Java
Stars
9.5k
Forks
2.9k
Avg merge
1d 7h
Merged PRs (30d)
6

Description

public class SseHttpClientTransportAutoConfiguration {
@Bean
public List sseHttpClientTransports(...) {

	......
		HttpClientSseClientTransport.Builder transportBuilder = HttpClientSseClientTransport.builder(baseUrl)
			.sseEndpoint(sseEndpoint)
			.clientBuilder(HttpClient.newBuilder())
			.objectMapper(objectMapper);
	......
	}
	return sseTransports;
}

}

.clientBuilder(HttpClient.newBuilder())

SseHttpClientTransportAutoConfiguration needs to support custom injection of HttpClient.Builder to facilitate scenarios where SSL needs to be disabled

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at SseHttpClientTransportAutoConfiguration and trace the sseHttpClientTransports bean shown in the issue. Determine how a custom HttpClient.Builder can be supplied for this configuration, including SSL-related use cases; done means the builder is injectable and used instead of always creating HttpClient.newBuilder().

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring-boot
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.