VectorStore filter improve

Open
#3,739 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
java
Domain
databases

Research direction

Start with Filter.java and trace how ExpressionType is consumed by the filter system and vector store implementations. Define completion as allowing implementations such as Milvus to provide custom operations like json_contains_any while preserving the existing operations and their current behavior.

Written by the indexing model from the issue text.

Description

enhancement milvus vector store

in my case, i use milvus and want to use json_contains_any

Proposal: Make ExpressionType an Interface for Extensibility

Problem

The current implementation of ExpressionType in Filter.java is an enum with fixed operation types (AND, OR, EQ, NE, etc.). This limits the ability of vector store implementations to support custom operation types that might be specific to their underlying storage systems.

Current Implementation
public enum ExpressionType {
    AND, OR, EQ, NE, GT, GTE, LT, LTE, IN, NIN, NOT
}
Proposed Solution

Convert ExpressionType from an enum to an interface, allowing different vector store implementations to define their own operation types. This would make the filter system more flexible and extensible.

Dominant language
Java
Stars
9.5k
Forks
2.9k
Avg merge
1d 10h
Merged PRs (30d)
5

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from spring-projects/spring-ai

All issues in spring-projects/spring-ai

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.