Is the `embeddingDistance` Method in `PgVectorStore` Necessary?

Open
#3,630 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
java
Domain
databases

Research direction

Start by inspecting the PgVectorStore implementation and searching the repository for embeddingDistance callers. Determine whether the method is part of the supported API; done means either documenting it with corresponding test coverage or removing it, based on that decision.

Written by the indexing model from the issue text.

Description

status: waiting-for-triage

The documentation does not provide an explanation for the embeddingDistance method, nor does it include any test code.
It also seems that it is not being used internally either.

If this method is necessary, it would be helpful to add explanations and corresponding test cases. Conversely, if it is not being used, it might be better to remove it.

@tzolov

Dominant language
Java
Stars
9.5k
Forks
2.9k
Avg merge
1d 10h
Merged PRs (30d)
5

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from spring-projects/spring-ai

All issues in spring-projects/spring-ai

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.