spring-projects / spring-projects/spring-ai
Most of classes implementing BaseAdvisor lacks logs
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.5k
- Forks
- 2.9k
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 6
Description
Most of the Advisor classes lack logging.
It is difficult to verify whether the advisor was invoked.
Specifically, ### QuestionAnswerAdvisor, VectorStoreChatMemoryAdvisor.
Would it be nice if SimpleLoggerAdvisor included some insights from other advisors as well?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating BaseAdvisor implementations, especially QuestionAnswerAdvisor and VectorStoreChatMemoryAdvisor, and inspect how SimpleLoggerAdvisor currently reports advisor activity. Determine which invocation details should be logged consistently, then verify that the selected advisors produce useful logs without duplicating existing output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- ai, observability
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100