spring-projects / spring-projects/spring-ai

Bug: Document class causes assertion failure when 'content' is missing in JSON

Open
#2,279 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

status: waiting-for-triage
Dominant language
Java
Stars
9.5k
Forks
2.9k
Avg merge
1d 7h
Merged PRs (30d)
6

Description

Image

The Document class in the spring-ai library has a potential bug in its JSON deserialization. When a Document instance is created from JSON and the content field is missing or null, it results in text being null. This leads to an assertion failure due to the following condition:

Assert.isTrue(text != null ^ media != null, "exactly one of text or media must be specified");

However, the Document class does not actually define a content field. Instead, it maps content to text using @JsonProperty("content"), which can cause unintended behavior.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Document class in the spring-ai library and inspect its JSON deserialization, especially the @JsonProperty("content") mapping and the assertion requiring exactly one of text or media. Reproduce deserialization with content missing and with content set to null, then add coverage and confirm the assertion behavior matches the intended handling.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.