spring-cloud / spring-cloud/spring-cloud-vault

Consider HA connection state for Vault standby health

Open
#953 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
291
Forks
152
Avg merge
11h 24m
Merged PRs (30d)
3

Description

Spring Cloud Vault's HealthBuilderDelegate currently reports any unsealed standby Vault node as UP. Vault's sys/health response includes ha_connection_healthy for standby nodes; a standby without a healthy HA connection should not be considered healthy by actuator health.

Context:

  • Vault returns 429 for standby sys/health responses by default, with a response body containing standby=true and ha_connection_healthy.
  • Spring Vault PR https://github.com/spring-projects/spring-vault/pull/1007 exposes ha_connection_healthy through VaultHealth and aligns reactive sys/health error-body handling with the blocking implementation.
  • Once Spring Cloud Vault consumes a Spring Vault version with that field, HealthBuilderDelegate could treat standby health as UP only when ha_connection_healthy is true, and DOWN otherwise.

Suggested semantics:

  • initialized=false -> DOWN
  • sealed=true -> DOWN
  • standby=true && ha_connection_healthy=true -> UP
  • standby=true && ha_connection_healthy!=true -> DOWN
  • performance_standby=true -> UP
  • active -> UP

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with Spring Cloud Vault's HealthBuilderDelegate and review how VaultHealth represents the sys/health response, including the Spring Vault change linked in the issue. Verify the actuator health mapping for initialized, sealed, standby, performance-standby, and active nodes; done means a standby is UP only when ha_connection_healthy is true.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
backend, cloud
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.