spring-cloud / spring-cloud/spring-cloud-vault

SslConfiguration should accept blank password for keystore

Open
#746 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
291
Forks
152
Avg merge
11h 24m
Merged PRs (30d)
3

Description

SslConfiguration should accept blank password for keystore instead of defaulting password to null when it is blank

https://github.com/spring-cloud/spring-cloud-vault/blob/main/spring-cloud-vault-config/src/main/java/org/springframework/cloud/vault/config/VaultConfiguration.java#L78-L83

The keystores exported from Azure Key Vault have a blank password which at the moment can't be used due to this. https://learn.microsoft.com/en-us/azure/key-vault/certificates/how-to-export-certificate?tabs=azure-cli#export-stored-certificates

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with spring-cloud-vault-config/src/main/java/org/springframework/cloud/vault/config/VaultConfiguration.java at lines 78-83 and inspect how a blank keystore password is handled. Use the Azure Key Vault export behavior described in the issue as the reproduction context. Done means SslConfiguration accepts a blank password instead of converting it to null.

Written by the indexing model from the issue text.

Assessment

Tech stack
azure, java
Domain
cloud, security
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.