spring-cloud / spring-cloud/spring-cloud-vault
Make methods in VaultConfigDataLoader and VaultConfigDataLocationResolver more accessible (protected/public)
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 291
- Forks
- 152
- Avg merge
- 11h 24m
- Merged PRs (30d)
- 3
Description
When extending VaultConfigDataLoader and VaultConfigDataLocationResolver for customized development, I encountered some obstacles. Certain methods in these classes are set to private, making it impossible to reuse existing logic or override specific behaviors when inheriting these classes.
To enable more flexible extensibility, I suggest changing the access modifiers of these methods from private to protected or public.
If this suggestion is accepted, I am willing to create a merge request for this change.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading spring-cloud-vault-config/src/main/java/org/springframework/cloud/vault/config/VaultConfigDataLoader.java and VaultConfigDataLocationResolver.java, focusing on private methods that prevent subclass customization. Identify which methods need protected or public visibility, then verify that extended classes can reuse or override the intended logic without changing existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend, cloud
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100