spring-cloud / spring-cloud/spring-cloud-vault
Suggest to use Accepted Profiles instead of Active Profiles
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 291
- Forks
- 152
- Avg merge
- 11h 24m
- Merged PRs (30d)
- 3
Description
Is your feature request related to a problem? Please describe.
If profiles are set only through spring.profiles.default property, spring-cloud-vault cannot process for this profiles.
Describe the solution you'd like
I expect this to be resolved by using Profiles::getAccepted() instead of Profiles::getActive() in VaultConfigDataLocationResolver.getKeyValueProperties()
Describe alternatives you've considered
No
Additional context
With application.yml as below
spring:
profiles:
default: development
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in VaultConfigDataLocationResolver.getKeyValueProperties() and inspect how profiles are obtained for Vault configuration. Reproduce the case using application.yml with spring.profiles.default set to development, then verify that the default profile is processed as requested.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- backend, cloud
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100