spring-cloud / spring-cloud/spring-cloud-vault

spring.cloud.config.databases latest version 4.0.1 still has spring.factories

Open
#687 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
291
Forks
152
Avg merge
11h 24m
Merged PRs (30d)
3

Description

Hello,

spring.cloud.config.databases is loaded with spring boot 3.0.5 as spring cloud version 2022.0.1 needs spring boot 3.0.5.

So seems like with this combination we cannot use database backend with vault anymore. As nothing is started to create creds for database as such.

We need to fix this library to be able to use with spring cloud version 2022.0.1. I see that spring-vault-consul has been updated to use latest guidance to migrate from spring.factories into META-INF/spring/.imports. But spring.cloud.config.databases and some others are still there. So not usable with Spring Boot 3.0.*.

According to https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0.0-M5-Release-Notes. spring.factories not supported anymore. So this breaks the use of new spring cloud version with spring.cloud.config.databases

Thanks

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the spring.cloud.config.databases integration and compare its spring.factories loading with the spring-vault-consul migration to META-INF/spring/.imports. Check the Spring Boot 3.0 compatibility guidance and verify that the database backend with Vault starts the credential-creation process under Spring Cloud 2022.0.1.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring-boot
Domain
backend, cloud, databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.