spring-cloud / spring-cloud/spring-cloud-vault

Add configuration option for X-Vault-Request header

Open
#639 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

status: waiting-for-triage
Dominant language
Java
Stars
291
Forks
152
Avg merge
11h 24m
Merged PRs (30d)
3

Description

Is your feature request related to a problem? Please describe.
When vault agent is configured to enforce X-Vault-Request header requirement, spring vault would error out with

missing 'X-Vault-Request' header; nested exception is org.springframework.web.client.HttpClientErrorException: 412 Precondition Failed: "{"errors":["missing 'X-Vault-Request' header"]}<EOL>"

Describe the solution you'd like
A configuration option to add the X-Vault-Request header in all requests to vault.

Describe alternatives you've considered
We have turned off the X-Vault-Request header requirement from vault agent side for now.

Additional context
Vault documentation: https://www.vaultproject.io/api-docs#the-x-vault-request-header

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no repository file, test, or entry point. Start by locating how Spring Vault builds requests and reads client configuration, then consult the linked Vault documentation for X-Vault-Request. Done means a configuration option adds the header to all Vault requests and the behavior is covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
backend, cloud
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.