spring-cloud / spring-cloud/spring-cloud-vault

Add support for DiscoveryClient when using ConfigData and AutoConfiguration-based activation

Open
#487 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: enhancement
Dominant language
Java
Stars
291
Forks
152
Avg merge
11h 24m
Merged PRs (30d)
3

Description

We should detect whether a DiscoveryClient is available so we can configure an appropriate VaultEndpointProvider. We have already support in the boostrap context, but with moving the activation into ConfigData-based activation, we should consider a DiscoveryClient in the ConfigDataLoader and in our auto-configuration.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the existing DiscoveryClient support in the bootstrap context, then inspect the ConfigDataLoader and auto-configuration paths named in the issue. Trace how VaultEndpointProvider is selected and ensure DiscoveryClient availability is considered in both ConfigData-based activation and auto-configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
backend, cloud
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.