spring-cloud / spring-cloud/spring-cloud-stream

Feature Request: Add maxAge to the binder properties

Open
#2,856 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Java
Stars
1.1k
Forks
646
Avg merge
2d 3h
Merged PRs (30d)
8

Description

Hello,

Coming from here: https://stackoverflow.com/questions/77510784/how-work-maxage-in-spring-kafka-factory-producer/77517766#77517766

Now you need to manually set maxAge for each binder programmatically, example:

    @Bean
    KafkaTransactionManager customKafkaTransactionManager() {
        KafkaMessageChannelBinder kafka = (KafkaMessageChannelBinder)this.binderFactory.getBinder("kafka1", MessageChannel.class);
        DefaultKafkaProducerFactory<byte[], byte[]> producerFactory = (DefaultKafkaProducerFactory<byte[], byte[]>) kafka.getTransactionalProducerFactory();

        producerFactory.setMaxAge(Duration.ofSeconds(60));

        return new KafkaTransactionManager(producerFactory);
    }

It would be good to add the possibility of configuring this property in each binder from the application properties in yaml. For example spring.cloud.stream.kafka.binder.transaction.maxAge in ms

Thanks

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the Kafka binder transaction configuration and the producer factory setup described in the issue, then identify the binder properties and application YAML binding path. Done means each binder can configure the producer factory's maxAge through the proposed transaction property, with tests covering the configured value.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, kafka, spring
Domain
backend, stream-processing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.