spring-cloud / spring-cloud/spring-cloud-stream
spring-cloud-stream-binder-kafka-reactive ignores message converter configuration for producer message handler
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 646
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 8
Description
Describe the issue
spring-cloud-stream-binder-kafka-reactive ignores message converter configuration for producer message handler.
It just creates MessagingMessageConverter instance disrespecting user provided properties and beans.
See https://github.com/spring-cloud/spring-cloud-stream/blob/v4.0.4/binders/kafka-binder/spring-cloud-stream-binder-kafka-reactive/src/main/java/org/springframework/cloud/stream/binder/reactorkafka/ReactorKafkaBinder.java#L200
To Reproduce
Steps to reproduce the behavior:
- Provide a custom header mapper via
spring.cloud.stream.kafka.binder.header-mapper-bean-name - Run app
- Producer uses default mapper (while consumer uses overridden one.
Version of the framework
v4.0.4
Expected behavior
org.springframework.cloud.stream.binder.kafka.utils.BindingUtils#getConsumerMessageConverter is used to create a message converter (or any other way you prefer) to respect provided properties
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in binders/kafka-binder/spring-cloud-stream-binder-kafka-reactive/src/main/java/org/springframework/cloud/stream/binder/reactorkafka/ReactorKafkaBinder.java around line 200, then compare the producer path with BindingUtils#getConsumerMessageConverter. Reproduce the issue with a custom header mapper configured through spring.cloud.stream.kafka.binder.header-mapper-bean-name; done means the producer respects the supplied converter configuration instead of using the default mapper.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, kafka, spring
- Domain
- backend, stream-processing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100