spring-cloud / spring-cloud/spring-cloud-stream
KafkaStreamsBinder bootstrapping refactor
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 646
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 8
Description
Now that I see this block of code, it is identical to the code in FDC above. It might we worth exploring moving it up as a whole to the KSBU instead of just the `findTargetMethod`, I would envision something like `findFunctionByName`. Wdyt?
Originally posted by @onobc in https://github.com/spring-cloud/spring-cloud-stream/pull/2738#discussion_r1199493211
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The discussion identifies duplicated code in the KafkaStreamsBinder area and names findTargetMethod, KSBU, FDC, and a possible findFunctionByName entry point. Start by locating those references and comparing the duplicated blocks; done means the shared bootstrapping logic has been consolidated without changing the binder behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, kafka
- Domain
- stream-processing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100