spring-cloud / spring-cloud/spring-cloud-stream

MessageConverter filtering breaks XML support

Open
#1,989 3 comments 0 reactions 1 assignee View on GitHub

@olegz is already working on this.

Since Jun 30, 2020.

enhancement
Dominant language
Java
Stars
1.1k
Forks
646
Avg merge
2d 3h
Merged PRs (30d)
8

Description

Describe the issue
Since https://github.com/spring-cloud/spring-cloud-stream/issues/1920, the ContentTypeConfiguration won't accept MessageConverters that reside inside org.springframeworkbut not org.springframework.cloud anymore.
In our case this hits org.springframework.messaging.converter.MappingJackson2MessageConverter so XML support via jackson is effectively disabled.

To Reproduce
Steps to reproduce the behavior:

  1. Include com.fasterxml.jackson.dataformat:jackson-dataformat-xml as dependency
  2. Try to send a message with contentType=application/xml
  3. See error: Failed to convert message [...] contentType=application/xml [...] to outbound message

Version of the framework
Versions that work: Hoxton.SR2
Versions that don't work: Hoxton.SR3

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.