spring-cloud / spring-cloud/spring-cloud-openfeign

Inconsistent Pageable Sort serialization between openfeign and spring mvc

Open
#675 10 comments 10 reactions 1 assignee View on GitHub

@OlgaMaciaszek is already working on this.

Since Feb 22, 2022.

icebox waiting for votes
Dominant language
Java
Stars
1.3k
Forks
838
Avg merge
2d 11h
Merged PRs (30d)
13

Description

  • spring boot version: 2.6.3
  • spring cloud version: 2021.0.0 (spring cloud openfeign 3.1.0)

spring serializes Sort as an object

"sort": { "empty": true, "sorted": false, "unsorted": true }

when SortJacksonModule is enabled (feign.autoconfiguration.jackson.enabled: true) Sort is serialize as an array by SortJsonComponent.SortSerializer.

"sort": []

since SortJacksonModule is in the spring context the controller response includes the Sort array creating inconsistency between the controller response with and without SortJacksonModule

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.