spring-cloud / spring-cloud/spring-cloud-openfeign
Support retries for non-loadbalanced requests
Open
@OlgaMaciaszek is already working on this.
Since Apr 26, 2021.
enhancement
- Dominant language
- Java
- Stars
- 1.3k
- Forks
- 838
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 13
Description
Java 11
Spring Boot 2.3.10.RELEASE
Spring Cloud Hoxton.SR11
Spring Retry 1.2.5.RELEASE
When I create FeignClient with attribute url, load balancer retry doesn't work. In the previous version (Hoxton.SR10) it worked.
Sample: DemoFeignNotRetryApplicationTests
correctRetry test shows that FeignClient without url was retried.
retryDoesNotWork test shows that FeignClient with url wasn't retried.
I think it related to RetryableFeignBlockingLoadBalancerClient does not respect 'url' parameter of @FeignClient.
@OlgaMaciaszek Could you please check?
Thank you!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.