spring-cloud / spring-cloud/spring-cloud-openfeign
feign.httpclient.disable-ssl-validation = true doesn't disable ssl validation for HttpClient
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.3k
- Forks
- 838
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 13
Description
You can further customise http clients by setting values in the spring.cloud.openfeign.httpclient.xxx properties.
feign.httpclient.disable-ssl-validation should apply to all clients.
Interestingly, this parameter doesn't seem to apply to http2Client configuration. Or I did miss something.
Same for the default client if no client is specified.
Here the configuration:
https://github.com/spring-cloud/spring-cloud-openfeign/blob/main/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/clientconfig/Http2ClientFeignConfiguration.java#L39-L53
isDisableSslValidation applies to hc5 and okhttp3 but not http2Client nor default client (jdk httpClient from feign).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read Http2ClientFeignConfiguration.java at the linked lines and compare its handling with the isDisableSslValidation usages found by the linked repository search. Trace the default JDK HttpClient path as well as the http2Client configuration. Done means feign.httpclient.disable-ssl-validation is honored consistently by the affected clients.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100