spring-cloud / spring-cloud/spring-cloud-openfeign
Feign Metrics not exposed in AOT mode via `MicrometerCapability`
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.3k
- Forks
- 838
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 13
Description
Now, I realise that the issue isn't actually in SC open feign, and feign doesn't officially support AOT, but nevertheless there is a FeignHints registrar, so i think it won't hurt extending it.
I suspect that Capability-s in general don't work in native at all for two reasons:
- The way capabilities are registered/enriched via reflection (using method names and return types). This can be fixed by adding hints for
MicrometerCapabilityand other default ones. - The way enrich-able fields are collected by scanning Builders. This can be fixed by adding hints for
BaseBuilderand its child classes.
Unfortunately, I don't have the time to make a proper contribution with tests etc.
Thanks in advance
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the FeignHints registrar and compare the reflection paths in Capability and BaseBuilder mentioned in the issue, including MicrometerCapability and BaseBuilder subclasses. Verify how capabilities behave in AOT or native mode, then add the necessary hints and tests so Feign metrics are exposed there.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100