spring-cloud / spring-cloud/spring-cloud-openfeign
Dynamically set Content-Type via @RequestHeader
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.3k
- Forks
- 838
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 13
Description
I want to set the Content-Type header programatically. When I try this happens:
Caused by: feign.codec.EncodeException: Invalid mime type "{Content-Type}": does not contain '/'
at feign.ReflectiveFeign$BuildEncodedTemplateFromArgs.resolve(ReflectiveFeign.java:346)
at feign.ReflectiveFeign$BuildTemplateByResolvingArgs.create(ReflectiveFeign.java:213)
at feign.SynchronousMethodHandler.invoke(SynchronousMethodHandler.java:72)
at feign.hystrix.HystrixInvocationHandler$1.run(HystrixInvocationHandler.java:108)
at com.netflix.hystrix.HystrixCommand$2.call(HystrixCommand.java:301)
at com.netflix.hystrix.HystrixCommand$2.call(HystrixCommand.java:297)
at rx.internal.operators.OnSubscribeDefer.call(OnSubscribeDefer.java:46)
... 27 common frames omitted
Caused by: org.springframework.http.InvalidMediaTypeException: Invalid mime type "{Content-Type}": does not contain '/'
at org.springframework.http.MediaType.parseMediaType(MediaType.java:425)
at org.springframework.http.MediaType.valueOf(MediaType.java:410)
at org.springframework.cloud.netflix.feign.support.SpringEncoder.encode(SpringEncoder.java:64)
at feign.ReflectiveFeign$BuildEncodedTemplateFromArgs.resolve(ReflectiveFeign.java:342)
... 33 common frames omitted
Caused by: org.springframework.util.InvalidMimeTypeException: Invalid mime type "{Content-Type}": does not contain '/'
at org.springframework.util.MimeTypeUtils.parseMimeType(MimeTypeUtils.java:239)
at org.springframework.http.MediaType.parseMediaType(MediaType.java:422)
... 36 common frames omitted
@FeignClient("x")
public interface XClient {
@RequestMapping(value = "/api/something/{id}", method = POST)
void x(@RequestHeader("Content-Type") String contentType, @PathVariable("id") Integer id,
@RequestBody InputStream inputStream);
}
I ended up having to set a X-Content-Type2 header and setting up one of these:
@Bean
public RequestInterceptor contentTypeFilter() {
return (req) -> {
req.header("Content-Type", req.headers().get("X-Content-Type2").iterator().next());
};
}
I am using:
spring-cloud-netflix-core-1.2.5.RELEASE.jar
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading SpringEncoder.java at the media-type parsing path shown in the stack trace, then inspect how the @RequestHeader("Content-Type") argument in the Feign client interface is resolved. Reproduce the request and verify that a dynamic Content-Type is accepted without requiring an alternate header or RequestInterceptor workaround.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100