spring-cloud / spring-cloud/spring-cloud-netflix
Document Sidecar's Properties that override normal eureka instance properties
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 5k
- Forks
- 2.5k
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 10
Description
We are using Brixton.M5 and I noticed that the port being registered with Eureka is incorrect. The SidecarConfiguration registers its own copy of the EurekaInstanceConfigBean.
The server port is injected as a value into the configuration class but never used. Instead it only consults the "sidecar" properties.
This should be a pretty easy fix: If the sidecar properties are not defined, fallback to logic that is similar to that found in EurekaClientAutoConfiguration.eurekaInstanceConfigBean.
@spencergibb Let me know if you would like help with this one, I can put a pull request together.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing SidecarConfiguration with EurekaClientAutoConfiguration.eurekaInstanceConfigBean, focusing on how the server port and sidecar properties are selected. Done means that, when sidecar properties are absent, the registered Eureka port follows the normal instance configuration behavior; verify the affected configuration path with the project's tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring-boot
- Domain
- backend, distributed-systems
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100