spring-cloud / spring-cloud/spring-cloud-netflix
Memory leak while deploying spring-cloud-netflix application on standalone tomcat
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 5k
- Forks
- 2.5k
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 10
Description
Tomcat fail to stop thread named ServoMonitorGetValueLimiter.
A thread called ServoMonitorGetValueLimiter started by the the application which is never stopped. This thread is started by MonitorRegistryMetricPoller of com.netflix.servo . In fact service is failed to stop the thread. The object of this class is a component in ServoMetricCollector of org.springframework.cloud.netflix.servo to exposes servo metrics to the metric endpoint.
when application is undeployed it is unable to unregister the MBean also (com.netflix.servo)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading MonitorRegistryMetricPoller and ServoMetricCollector, then trace how the metric endpoint creates and manages the Servo monitor. Reproduce an undeploy on standalone Tomcat and verify that ServoMonitorGetValueLimiter stops and the com.netflix.servo MBean is unregistered; the issue is done when no thread or MBean remains after undeployment.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring, spring-boot
- Domain
- backend, observability
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100