spring-cloud / spring-cloud/spring-cloud-netflix
Fix selecting HTTP client builders for Eureka Client
@OlgaMaciaszek is already working on this.
Since Dec 2, 2024.
- Dominant language
- Java
- Stars
- 5k
- Forks
- 2.5k
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 10
Description
Currently, if there's a builder bean for HTTP client (RestClient.Builder, WebClient.Builder, etc.) created by the user, it's used for creating the client used for communication with Eureka. The problem with this approach is that it's not readily visible for the users and we may end up using builder beans with a setup that was not intended by the users to be used for communicating with Eureka (for example, a @LoadBalanced RestClient.Builder). Consider switching to an approach where if there's a builder identified by the user for this specific purpose (for example, by a specific supplier function or interface), it's used, if not, we create our own and use available configurers/customisers on it to make sure the Boot-provided capabilities, such as metrics support are there.
See:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.