spring-cloud / spring-cloud/spring-cloud-netflix
Duplicate event: EurekaInstanceCanceledEvent
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 5k
- Forks
- 2.5k
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 10
Description
Describe the bug
An application that actively unregisters from eureka fires EurekaInstanceCanceledEvent twice.
The REST endpoint for unregister is executed. The first event is fired, as handleCancelation was added directly to the overridden cancel method. The original cancel method delegates to internalCancel which again was overridden by spring and handleCancelation was added there too.
I think it should be save to remove the overridden cancel method and only keep internalCancel.
WDYT?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the REST unregister endpoint and trace the cancellation path through the overridden cancel and internalCancel methods, focusing on where handleCancelation is invoked. Verify that removing the duplicate invocation leaves EurekaInstanceCanceledEvent emitted once; done means an active unregister produces a single event.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100