spring-cloud / spring-cloud/spring-cloud-netflix
Eureka instance is using non-secure port to construct `secureHealthCheckUrl`
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 5k
- Forks
- 2.5k
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 10
Description
Given eureka instance configuration as follows:
eureka:
instance:
secure-port: 443
secure-port-enabled: true
non-secure-port: 80
non-secure-port-enabled: false
The generated EurekaInstanceConfigBean uses the non-secure-port to construct both healthCheckUrl and secureHealthCheckUrl. (https://github.com/spring-cloud/spring-cloud-netflix/blob/master/spring-cloud-netflix-eureka-client/src/main/java/org/springframework/cloud/netflix/eureka/metadata/DefaultManagementMetadataProvider.java#L58)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at spring-cloud-netflix-eureka-client/src/main/java/org/springframework/cloud/netflix/eureka/metadata/DefaultManagementMetadataProvider.java#L58 and compare how the configured secure and non-secure ports are used for healthCheckUrl and secureHealthCheckUrl. Done means the secure health-check URL uses the configured secure port while the regular URL retains the non-secure port.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- backend, cloud
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100