Race condition with registration events in Eureka server

I believe I have found a race condition with the spring-cloud-netflix-eureka-server (Edgware) module concerning registration of instances.
When an instance on the Eureka server registers, an EurekaInstanceRegisteredEvent is emitted by InstanceRegistry. Unfortunately, this event is emitted before the actual registration has taken place in the InstanceRegistry itself. Typically, one would handle this event and rely on the fact that the registration process has been completed to be able to query the registry for the new state. Especially since the class is called EurekaInstanceRegister_ED_Event.

If you have a look at the source ode of org.springframework.cloud.netflix.eureka.server.InstanceRegistry line 85+86 you can see that the event is published before super.register is called.

This behaviour affects all three events EurekaInstanceRegisteredEvent, EurekaInstanceCanceledEvent and EurekaInstanceRenewedEvent.

I am happy to provide a pull request that fixes this, unless this behaviour is on purpose (for some reason).

Start by reading org.springframework.cloud.netflix.eureka.server.InstanceRegistry around lines 85-86 and trace how registration, cancellation, and renewal events are published relative to the superclass operation. Verify whether each event can observe the registry's updated state. Done means all three events are emitted only after their corresponding registry operation has completed, with regression coverage for the ordering.