spring-cloud / spring-cloud/spring-cloud-netflix
RequestSpecificRetryHandler retries same server for SERVER_THROTTLED
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 5k
- Forks
- 2.5k
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 10
Description
Netflix's RequestSpecificRetryHandler allows to retry on same server for SERVER_THROTTLED error.
When the okToRetryOnAllErrors property is true, the retry handler allows to retry on the same server unconditionally without taking into account the actual error. This is useless when the server responded with SERVER_THROTTLED.
It looks like the if statement at https://github.com/Netflix/ribbon/blob/master/ribbon-core/src/main/java/com/netflix/client/RequestSpecificRetryHandler.java#L58-L65 should be considered first before the other conditions.
I doubt Netflix is willing to change this behavior but we could override it in SpringCloud.
What do you think ?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with Netflix Ribbon's RequestSpecificRetryHandler.java at the referenced lines, then trace where Spring Cloud integrates or overrides this retry behavior. Verify how SERVER_THROTTLED is handled when okToRetryOnAllErrors is true; done means the same server is not retried for that error, with regression coverage if an appropriate test location is found.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- backend, distributed-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100