spring-cloud / spring-cloud/spring-cloud-kubernetes
Allow using Watcher when ConfigMaps and Secrets are maintained by external team
A pull request for this has already been merged.
- #1660 by @wind57 — merged
- Dominant language
- Java
- Stars
- 3.5k
- Forks
- 1.1k
- Avg merge
- 18h 36m
- Merged PRs (30d)
- 18
Description
Is your feature request related to a problem? Please describe.
I want to use Spring Cloud Kubernetes Configuration Watcher to monitor and call /refresh for shared ConfigMaps and Secrets maintained by centralised platform team in my project.
The problem is that I do not have permissions to add necessary labels:
spring.cloud.kubernetes.secret/spring.cloud.kubernetes.secret.informer.enabledspring.cloud.kubernetes.config/spring.cloud.kubernetes.config.informer.enabled
and annotations
spring.cloud.kubernetes.secret.apps/spring.cloud.kubernetes.configmap.apps
in order for Watcher to fire the /refresh calls to the apps.
Note! I do have permissions for getting, listing and watching these ConfigMaps and Secrets, but not editing them.
Documentation I have used so far:
- https://docs.spring.io/spring-cloud-kubernetes/docs/current/reference/html/#spring-cloud-kubernetes-configuration-watcher
- https://docs.spring.io/spring-cloud-kubernetes/docs/current/reference/html/#monitoring-configmaps-and-secrets
Describe the solution you'd like
What would really help is that it was possible (as an alternative solution) to explicitly configure the name of ConfigMaps and Secrets in the Watcher deployment, as environment variables, in addition to which apps to refresh. Or, if you have any suggestion on an alternative solution, not requiring changes to the ConfigMap and Secret resources.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the configuration watcher documentation sections linked in the issue, then review the closed pull request #1660 to understand the work already undertaken. Compare that approach with the requested ability to target externally maintained ConfigMaps and Secrets without labels or annotations, and verify whether refresh calls for the configured applications are covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, kubernetes, spring, spring-boot
- Domain
- backend, cloud, infrastructure
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100