spring-cloud / spring-cloud/spring-cloud-gateway

Use new DataSize class in Spring Framework 5.1

Open
#493 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Java
Stars
4.9k
Forks
3.5k
Avg merge
20h 57m
Merged PRs (30d)
8

Description

Can be used in RequestSizeFilter, possibly other places

https://github.com/spring-projects/spring-framework/blob/master/spring-core/src/main/java/org/springframework/util/unit/DataSize.java

Can only happen after the next boot milestone (currently m1).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading Spring Framework's DataSize class at spring-core/src/main/java/org/springframework/util/unit/DataSize.java, then locate RequestSizeFilter and other places where request sizes are represented. Confirm the required Spring Boot milestone is available before making changes. Done means the applicable gateway code uses DataSize consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring, spring-boot
Domain
api, backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.