spring-cloud / spring-cloud/spring-cloud-gateway
ReadBodyRoutePredicateFactory cannot predicate without body request
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 4.9k
- Forks
- 3.5k
- Avg merge
- 20h 57m
- Merged PRs (30d)
- 8
Description
When using ReadBody predicate, i found if a request without body, the predicate cannot be execute. Then check the ReadBodyRoutePredicateFactory code and found the doOnNext will not be execute if none request body.
There are many without body requests, and these requests need to use ReadBodyRoutePredicateFactory for predicate, and so, suggest ReadBodyRoutePredicateFactory can support without body request.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading ReadBodyRoutePredicateFactory and reproduce the reported behavior with a request that has no body. Confirm how the predicate is invoked for bodyless requests and verify that the completed behavior supports those requests without breaking requests that include a body.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring, spring-boot
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100