spring-cloud / spring-cloud/spring-cloud-gateway
request_rate_limiter.lua should use milliseconds
Open
Nobody has claimed this yet.
feedback-provided
- Dominant language
- Java
- Stars
- 4.9k
- Forks
- 3.5k
- Avg merge
- 20h 57m
- Merged PRs (30d)
- 8
Description
redis.call('TIME')[1] returns seconds, is it more reasonable to use milliseconds
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read spring-cloud-gateway-server-webflux/src/main/resources/META-INF/scripts/request_rate_limiter.lua at line 8 and the Redis TIME command documentation first. Confirm whether the rate limiter requires millisecond precision, then make the timestamp unit consistent with that requirement and verify the script's rate-limiting behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua, redis
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100