spring-cloud / spring-cloud/spring-cloud-gateway

Invalid shortcut field order configuration in circuit breaker filter factory

Open
#3,974 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

waiting-for-triage
Dominant language
Java
Stars
4.9k
Forks
3.5k
Avg merge
20h 57m
Merged PRs (30d)
8

Description

Hi,

We are building Spring Cloud Gateway with filters based on a database configuration. However, we’re facing issues when creating the CircuitBreaker filter due to missing parameters in the shortcut field order.

We expect the filter to be properly constructed from our configuration, but all parameters except "name" are being ignored because they are not included in the shortcut field order.

Here’s the the problem in SpringCloudCircuitBreakerFilterFactory:

	@Override
	public List<String> shortcutFieldOrder() {
		return singletonList(NAME_KEY);
	}

And other parameters in Config

	public static class Config implements HasRouteId {

		private String name;

		private URI fallbackUri;

		private String routeId;

		private Set<String> statusCodes = new HashSet<>();

		private boolean resumeWithoutError = false;

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in SpringCloudCircuitBreakerFilterFactory, compare shortcutFieldOrder() with the fields exposed by its Config class, including fallbackUri, routeId, statusCodes, and resumeWithoutError. Trace how route configuration binds shortcut arguments and identify the relevant existing tests or test entry points. Done means database-backed configuration preserves all intended CircuitBreaker parameters instead of only name.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring, spring-boot
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.